Messages in this thread | | | Date | Wed, 06 May 2015 14:15:08 -0600 | From | Shuah Khan <> | Subject | Re: [PATCH v2] selftests/mount: output WARN messages when mount test skipped |
| |
On 04/02/2015 07:39 PM, Zhang Zhen wrote: > Without this patch, if /proc/self/uid_map is not exist, > the mount test case will skipped and no any prompting. > > After applied this patch, the case will prompt why it skipped. > Just as follows: > root@kernel-host:/opt/kernel> make -C tools/testing/selftests TARGETS=mount run_tests > make: Entering directory `/opt/kernel/tools/testing/selftests' > for TARGET in mount; do \ > make -C $TARGET; \ > done; > make[1]: Entering directory `/opt/kernel/tools/testing/selftests/mount' > make[1]: Nothing to be done for `all'. > make[1]: Leaving directory `/opt/kernel/tools/testing/selftests/mount' > for TARGET in mount; do \ > make -C $TARGET run_tests; \ > done; > make[1]: Entering directory `/opt/kernel/tools/testing/selftests/mount' > if [ -f /proc/self/uid_map ] ; then ./unprivileged-remount-test ; else echo "WARN: No /proc/self/uid_map exist, test skipped." ; fi > WARN: No /proc/self/uid_map exist, test skipped. > make[1]: Leaving directory `/opt/kernel/tools/testing/selftests/mount' > make: Leaving directory `/opt/kernel/tools/testing/selftests' > > Change v1 -> v2: > - fix syntax error when run kselftest_install.sh > > Signed-off-by: Zhang Zhen <zhenzhang.zhang@huawei.com> > ---
Thanks for fixing this. Applied it to linux-kselftest next for 4.2 - I ended up making changes the commit log to fix checkpatch warnings before applying the patch.
thanks, -- Shuah
-- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978
| |