lkml.org 
[lkml]   [2015]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 2/9][v3]usb:fsl:otg: Add support to add/remove usb host driver
Date


> -----Original Message-----
> From: Alan Stern [mailto:stern@rowland.harvard.edu]
> Sent: Wednesday, May 06, 2015 7:49 PM
> To: Mehresh Ramneek-B31383
> Cc: Kernel development list; Felipe Balbi; USB list;
> gregkh@linuxfoundation.org
> Subject: RE: [PATCH 2/9][v3]usb:fsl:otg: Add support to add/remove usb
> host driver
>
> On Wed, 6 May 2015, Ramneek Mehresh wrote:
>
> > > Also, I'm not going to let you add new fields into the
> > > ehci_driver_overrides structure. If you really need to override
> > > other routines, copy the approach used by ehci-tegra.c.
> > >
> > Understood...but I would appreciate if you could please explain the
> > harm in doing so
>
> The fields in the override structure are meant for convenience. The
> extra_priv_size field is the most important one; the other two fields (reset
> and port_power) are present only because so many drivers need them.
>
> There's no reason to add an extra field for something that will be used in only
> one driver. You can do the override by hand, instead of wasting space in a
> whole bunch of other drivers.
>
Ok...i thought "overrides" structure is to enforce a field by a driver on generic structure...
But now it appears that it's only for most popular fields only...i'll make changes in my driver only

> Alan Stern



\
 
 \ /
  Last update: 2015-05-06 17:01    [W:0.086 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site