lkml.org 
[lkml]   [2015]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 201/208] x86/fpu: Clean up xstate feature reservation

* Dave Hansen <dave.hansen@linux.intel.com> wrote:

> On 05/05/2015 10:58 AM, Ingo Molnar wrote:
> > struct xregs_state {
> > struct fxregs_state i387;
> > struct xstate_header header;
> > - struct ymmh_struct ymmh;
> > - struct lwp_struct lwp;
> > - struct bndreg bndreg[4];
> > - struct bndcsr bndcsr;
> > - /* New processor state extensions will go here. */
> > + u8 __reserved[XSTATE_RESERVE];
> > } __attribute__ ((packed, aligned (64)));
>
> Just to reiterate. The size of 'XSTATE_RESERVE' is completely
> unknown at compile time. [...]

Yes, see my previous mail.

> [...] It's wrong in the existing kernel, but we should fix it up
> instead of mucking with it like this.

I'm not mucking with it, I'm slowly migrating it towards a dynamic
model that doesn't suck - see my other mails.

Thanks,

Ingo


\
 
 \ /
  Last update: 2015-05-06 07:21    [W:0.077 / U:2.308 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site