lkml.org 
[lkml]   [2015]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 1/1] clkdev: change prototype of clk_register_clkdev()
On Wed, May 06, 2015 at 01:24:12PM +0300, Andy Shevchenko wrote:
> Since clk_register_clkdev() is exported for modules the caller should get a
> pointer to the allocated resources. Otherwise the memory leak is guaranteed on
> the ->remove() stage.

clk_register_clkdev() is there to assist mass clock registrations, which
typically happen in platform code. It's there to simplify the "I need
to register this clock which I'm not going to release again".

I don't see any of these locations trying to unregister their clk from
clkdev, so I doubt this patch is needed.

Where a module wants to remove its clk from clkdev, it should register
its clk with clkdev_create() and remove it with clkdev_drop().

--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.


\
 
 \ /
  Last update: 2015-05-06 13:41    [W:0.044 / U:0.580 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site