Messages in this thread | | | Date | Wed, 6 May 2015 12:09:56 +0100 | From | Russell King - ARM Linux <> | Subject | Re: [PATCH v4 1/1] clkdev: change prototype of clk_register_clkdev() |
| |
On Wed, May 06, 2015 at 01:24:12PM +0300, Andy Shevchenko wrote: > Since clk_register_clkdev() is exported for modules the caller should get a > pointer to the allocated resources. Otherwise the memory leak is guaranteed on > the ->remove() stage.
clk_register_clkdev() is there to assist mass clock registrations, which typically happen in platform code. It's there to simplify the "I need to register this clock which I'm not going to release again".
I don't see any of these locations trying to unregister their clk from clkdev, so I doubt this patch is needed.
Where a module wants to remove its clk from clkdev, it should register its clk with clkdev_create() and remove it with clkdev_drop().
-- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net.
| |