lkml.org 
[lkml]   [2015]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 0/3] Dell Airplane Mode Switch driver
From
The test was updated @
https://docs.google.com/spreadsheets/d/1voffS6dNglwAExSGh3UmG__UAO2qfZ829CkJLPo06aI/edit?usp=sharing.
Please check the tab "Dell-rbtnv2"

Notes:
1. The systems come and go and I can find some of original ones but I
tests some others
2. Test 3 was done by Test 2 + "rmmod dell-laptop". All were run with
all wireless devices are ON

Summary:
From external behaves such as Desktop's viewpoint (Unity was used and
hope that's not surprising), the wireless devices are ON/OFF
correctly. Other details are listed in the report.

On Sun, May 3, 2015 at 6:38 PM, Pali Rohár <pali.rohar@gmail.com> wrote:
> On Wednesday 29 April 2015 11:51:03 Pali Rohár wrote:
>> This patch series add new acpi Dell Airplane Mode Switch
>> driver (DELLABCE and DELRBTN acpi devices). It provides radio
>> HW switch events (together with current state of radio
>> devices) and export them via rfkill interface. These events
>> are also used in dell-laptop driver instead i8042 filter hook
>> function (when acpi device is available).
>>
>> In v2 was added support for laptops which have toggle button
>> instead HW slider switch. For that I reused code done by Alex
>> Hung.
>>
>> Pali Rohár (3):
>> platform: x86: dell-rbtn: Dell Airplane Mode Switch driver
>> platform: x86: dell-rbtn: Export notifier for other kernel
>> modules platform: x86: dell-laptop: Use dell-rbtn instead
>> i8042 filter when possible
>>
>> drivers/platform/x86/Kconfig | 14 ++
>> drivers/platform/x86/Makefile | 1 +
>> drivers/platform/x86/dell-laptop.c | 67 +++++-
>> drivers/platform/x86/dell-rbtn.c | 430
>> ++++++++++++++++++++++++++++++++++++
>> drivers/platform/x86/dell-rbtn.h | 35 +++
>> 5 files changed, 542 insertions(+), 5 deletions(-)
>> create mode 100644 drivers/platform/x86/dell-rbtn.c
>> create mode 100644 drivers/platform/x86/dell-rbtn.h
>
> Alex, can you rested this patch series on all your machines like
> you did previous in this sheet?
>
> https://docs.google.com/spreadsheets/d/1voffS6dNglwAExSGh3UmG__UAO2qfZ829CkJLPo06aI/edit?usp=sharing
>
> Ideally do more tests:
> 1) only with first patch 1/3
> 2) with full patch series 1/3, 2/3, 3/3 *with* loaded dell-laptop
> 3) same as 2) but without loaded dell-laptop
>
> If everything pass then this patch series is OK from my side.
>
> Looks like Gabriele's problem is irrelevant to this patch series,
> but we probably hit some rfkill bug in dell-laptop.ko :-(
>
> Matthew or Darren, can you review code in this patch series? So
> if everything will be fine, dell-rbtn could be ready for 4.2.
>
> --
> Pali Rohár
> pali.rohar@gmail.com



--
Cheers,
Alex Hung


\
 
 \ /
  Last update: 2015-05-06 11:21    [W:2.867 / U:0.816 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site