lkml.org 
[lkml]   [2015]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] clk: bindings: Fix assigned-clock-rates property name
    On 06.05.2015 16:45, Stephen Boyd wrote:
    > On 05/06, Krzysztof Kozlowski wrote:
    >> In documentation the "assigned-clock-parents" name was used when
    >> describing the "assigned-clock-rates" property.
    >>
    >> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
    >> ---
    >
    > Looks right. The whole sentence could use some work though.
    >
    >> Documentation/devicetree/bindings/clock/clock-bindings.txt | 2 +-
    >> 1 file changed, 1 insertion(+), 1 deletion(-)
    >>
    >> diff --git a/Documentation/devicetree/bindings/clock/clock-bindings.txt b/Documentation/devicetree/bindings/clock/clock-bindings.txt
    >> index 06fc6d541c89..bf5b0414dc17 100644
    >> --- a/Documentation/devicetree/bindings/clock/clock-bindings.txt
    >> +++ b/Documentation/devicetree/bindings/clock/clock-bindings.txt
    >> @@ -138,7 +138,7 @@ Some platforms may require initial configuration of default parent clocks
    >> and clock frequencies. Such a configuration can be specified in a device tree
    >> node through assigned-clocks, assigned-clock-parents and assigned-clock-rates
    >> properties. The assigned-clock-parents property should contain a list of parent
    >> -clocks in form of phandle and clock specifier pairs, the assigned-clock-parents
    >> +clocks in form of phandle and clock specifier pairs, the assigned-clock-rates
    >> property the list of assigned clock frequency values - corresponding to clocks
    >
    > This half-sentence:
    >
    > The assigned-clock-ratse property the list of assigned
    > clock frequency values
    >
    > doesn't read correctly. Maybe the whole thing should be rewritten
    > as:
    >
    > The assigned-clock-parents property should contain a list
    > of parent clocks in the form of a phandle and clock
    > specifier pair and the assigned-clock-rates property
    > should contain a list of frequencies in Hz. Both these
    > properties should correspond to the clocks listed in the
    > assigned-clocks property.

    Looks much better. So actually this should be yours patch now, you can
    add my Reported-by :).

    Best regards,
    Krzysztof




    \
     
     \ /
      Last update: 2015-05-06 10:41    [W:3.047 / U:1.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site