Messages in this thread | | | Date | Wed, 6 May 2015 08:22:15 +0100 | From | Al Viro <> | Subject | Re: [PATCH 47/79] namei: move link/cookie pairs into nameidata |
| |
On Wed, May 06, 2015 at 12:42:54PM +1000, NeilBrown wrote: > > static int link_path_walk(const char *name, struct nameidata *nd) > > { > > - struct saved { > > - struct path link; > > - void *cookie; > > - const char *name; > > - } stack[MAX_NESTED_LINKS], *last = stack + nd->depth - 1; > > + struct saved *last = nd->stack; > > This looks wrong. 'last' used to be dependent on nd->depth, now it isn't.
On the entry to link_path_walk() we have nd->depth == 0.
And nd->depth and last are changed in sync.
| |