lkml.org 
[lkml]   [2015]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 04/79] ext4: split inode_operations for encrypted symlinks off the rest
On Tue, May 05, 2015 at 08:01:52AM -0700, Linus Torvalds wrote:
> Ugh. Could we aim to *not* add code like this.
>
> Instead, just declare (but don't define) the
> ext4_encrypted_symlink_inode_operations thing, so that *if* somebody
> uses it they get a link error, and make sure that
> "ext4_encrypted_inode()" ends up always returning zero when encryption
> isn't enabled, so that the compiler will actually optimize the whole
> thing out (which apparently is already the case, judging by the
> build-bug-on.

Sure, no problem. BUILD_BUG_ON was used only because it triggered an
error earlier, I simply forgot to rip it out afterwards.


\
 
 \ /
  Last update: 2015-05-05 19:41    [W:0.123 / U:12.392 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site