lkml.org 
[lkml]   [2015]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH RFC] checkpatch: flag split arithmetic operations with CHECK
From
Date
On Tue, 2015-05-05 at 16:08 +0200, Nicholas Mc Guire wrote:
> On Tue, 05 May 2015, Andy Whitcroft wrote:
> > On Tue, May 05, 2015 at 10:53:36AM +0200, Nicholas Mc Guire wrote:
> > > Simple arithmetic operations should be on one line, if they can be fit,
> > > rather than splitting at the operator. As this is not in the CodingStyle it
> > > is limited to --strict use of checkpatch.pl and emits a CHECK only.
[]
> > I assume that these relate to being able to confirm the variant of the
> > operator, unary/binary etc. If you look for "annotate_values", after
> > that is run there is additional information for each character of the
> > current line, tracking the type of the operator. This is used when
> > determining spacing for + etc later as unary ones are typically tight
> > bound and binary ones spaced out. You might find that useful, if that
> > is your issue. And indeed you might find it useful for determining if
> > the +/- you find at line end is indeed unary. Running with --debug
> > values=1 should dump out the variants information for those.
> >
> thanks - looks like a useful (somewhat cryptic) starting point
>
> 15 > . x = y - x
> 15 > EEEVVNNVVNNTTT
> 15 > ________B____
>
> will give it a try to generalize it for all basic binary operators.

Look at the code for "# Check operator spacing" around line 3600.
It's a pretty big block of ~300 lines of code, but this new test
should go in there.




\
 
 \ /
  Last update: 2015-05-05 18:41    [W:0.041 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site