lkml.org 
[lkml]   [2015]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 40/79] link_path_walk: turn inner loop into explicit goto
On Tue, May 05, 2015 at 08:09:04AM -0700, Linus Torvalds wrote:
> On Mon, May 4, 2015 at 10:22 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> > +l:
>
> This looked like noise.
>
> PLEASE. We're not programming in Pascal (and thank all Gods for that),
> so we can have labels that have meaningful names. Also, we're not
> ashamed of using goto where it makes sense, so we don't need to try to
> hide the labels by making them look like specks of dirt on our
> monitor.
>
> So give the label a real name that describes what it is. Not this kind of thing.

Something like this_used_to_be_the_beginning_of_loop_body?

Seriously, it's strictly temporary thing - it lives for two commits and
gets killed after that. Exactly because it has no good inherent meaning.
The label replacing it two commits later (several lines upstream) does,
and it gets better name...


\
 
 \ /
  Last update: 2015-05-05 18:41    [W:0.221 / U:3.784 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site