Messages in this thread | | | Subject | Re: [PATCH] adm8211: fix checkpatch errors for indentation and new line around switch-case | From | Joe Perches <> | Date | Tue, 05 May 2015 06:50:52 -0700 |
| |
On Tue, 2015-05-05 at 14:03 +0200, Peter Rosin wrote: > > diff --git a/drivers/net/wireless/adm8211.c b/drivers/net/wireless/adm8211.c [] > > @@ -1098,14 +1098,18 @@ static void adm8211_hw_init(struct ieee80211_hw *dev) > > pci_read_config_byte(priv->pdev, PCI_CACHE_LINE_SIZE, &cline); > > > > switch (cline) { [] > > + case 0x8: > > + reg |= (0x1 << 14); > > + break; > > + case 0x16: > > + reg |= (0x2 << 14); > > + break; > > + case 0x32: > > + reg |= (0x3 << 14); > > + break; > > + default: > > + reg |= (0x0 << 14); > > + break; > > } > > } > > > > Those 0x16/0x32 hexadecimal case-selectors looking suspiciously like > decimal bits need a comment if they are in fact correct, which I doubt.
Good spot.
As it's testing PCI_CACHE_LINE_SIZE, they seem very much broken.
| |