Messages in this thread | | | From | Anisse Astier <> | Date | Tue, 5 May 2015 14:42:11 +0200 | Subject | Re: [PATCH v2 2/4] mm/page_alloc.c: add config option to sanitize freed pages |
| |
On Mon, May 4, 2015 at 11:50 PM, PaX Team <pageexec@freemail.hu> wrote: > On 4 May 2015 at 23:16, Anisse Astier wrote: > >> @@ -960,9 +966,15 @@ static int prep_new_page(struct page *page, unsigned int order, gfp_t gfp_flags, >> kernel_map_pages(page, 1 << order, 1); >> kasan_alloc_pages(page, order); >> >> +#ifndef CONFIG_SANITIZE_FREED_PAGES >> + /* SANITIZE_FREED_PAGES relies implicitly on the fact that pages are >> + * cleared before use, so we don't need gfp zero in the default case >> + * because all pages go through the free_pages_prepare code path when >> + * switching from bootmem to the default allocator */ >> if (gfp_flags & __GFP_ZERO) >> for (i = 0; i < (1 << order); i++) >> clear_highpage(page + i); >> +#endif > > this hunk should not be applied before the hibernation fix otherwise > bisect will break. >
It will be re-ordered in v3, thanks.
| |