lkml.org 
[lkml]   [2015]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subject[BUG ?] MIPS: KVM: condition with no effect

Hi !

Not sure if this is a bug or maybe a placeholder for
something... so patch - but maybe someone that knows this code can
give it a look.

arch/mips/kvm/emulate.c:emulation_result kvm_mips_complete_mmio_load()
<snip>
2414 case 2:
2415 if (vcpu->mmio_needed == 2)
2416 *gpr = *(int16_t *) run->mmio.data;
2417 else
2418 *gpr = *(int16_t *) run->mmio.data;
2419
2420 break;
<snip>

either the if/else is not needed or one of the branches is wrong
or it is a place-holder for somethign that did not get
done - in which case a few lines explaining this would be
nice (e.g. like in arch/sh/kernel/traps_64.c line 59)

line numbers refer to 4.1-rc2

thx!
hofrat


\
 
 \ /
  Last update: 2015-05-05 15:01    [W:0.050 / U:0.456 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site