lkml.org 
[lkml]   [2015]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] KVM: remove pointless cpu hotplug messages
Am 05.05.2015 um 09:39 schrieb Heiko Carstens:
> On cpu hotplug only KVM emits an unconditional message that its notifier
> has been called. It certainly can be assumed that calling cpu hotplug
> notifiers work, therefore there is no added value if KVM prints a message.
>
> If an error happens on cpu online KVM will still emit a warning.
>
> So let's remove this superfluous message.
>
> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>

Its really the only code that I know of that is chatty on cpu hotplug.

Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>



> ---
> virt/kvm/kvm_main.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 90977418aeb6..5fb52af5b975 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -2882,18 +2882,12 @@ static int hardware_enable_all(void)
> static int kvm_cpu_hotplug(struct notifier_block *notifier, unsigned long val,
> void *v)
> {
> - int cpu = (long)v;
> -
> val &= ~CPU_TASKS_FROZEN;
> switch (val) {
> case CPU_DYING:
> - pr_info("kvm: disabling virtualization on CPU%d\n",
> - cpu);
> hardware_disable();
> break;
> case CPU_STARTING:
> - pr_info("kvm: enabling virtualization on CPU%d\n",
> - cpu);
> hardware_enable();
> break;
> }
>



\
 
 \ /
  Last update: 2015-05-05 13:41    [W:0.063 / U:0.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site