Messages in this thread | | | Date | Tue, 5 May 2015 23:29:51 +0200 | Subject | Re: [PATCH] remove <asm/scatterlist.h> | From | Geert Uytterhoeven <> |
| |
On Tue, May 5, 2015 at 10:41 PM, Christoph Hellwig <hch@lst.de> wrote: > On Tue, May 05, 2015 at 10:34:21PM +0200, Geert Uytterhoeven wrote: >> If you remove include/asm-generic/scatterlist.h, you have to update the >> various Kbuild files referring to it: > > Oh, I missed that and will fix it. But where does the missing removal > actually show up? During a normal build on a few architectures nothing > seemed to care.
There are indeed no errors or warnings from Kbuild if you remove a file from include/asm-generic. Only if you try to #include it, it will fail.
Ah, it just creates a file that includes the generic version, whether it exists or not:
$ cat arch/arm/include/generated/asm/scatterlist.h #include <asm-generic/scatterlist.h> $
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |