lkml.org 
[lkml]   [2015]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] remove <asm/scatterlist.h>
From
On Tue, May 5, 2015 at 10:41 PM, Christoph Hellwig <hch@lst.de> wrote:
> On Tue, May 05, 2015 at 10:34:21PM +0200, Geert Uytterhoeven wrote:
>> If you remove include/asm-generic/scatterlist.h, you have to update the
>> various Kbuild files referring to it:
>
> Oh, I missed that and will fix it. But where does the missing removal
> actually show up? During a normal build on a few architectures nothing
> seemed to care.

There are indeed no errors or warnings from Kbuild if you remove a
file from include/asm-generic. Only if you try to #include it, it will fail.

Ah, it just creates a file that includes the generic version, whether it
exists or not:

$ cat arch/arm/include/generated/asm/scatterlist.h
#include <asm-generic/scatterlist.h>
$

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds


\
 
 \ /
  Last update: 2015-05-06 00:01    [W:0.118 / U:0.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site