lkml.org 
[lkml]   [2015]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.13.y-ckt 90/90] ipv4: Missing sk_nulls_node_init() in ping_unhash().
    Date
    3.13.11-ckt20 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: "David S. Miller" <davem@davemloft.net>

    [ Upstream commit a134f083e79fb4c3d0a925691e732c56911b4326 ]

    If we don't do that, then the poison value is left in the ->pprev
    backlink.

    This can cause crashes if we do a disconnect, followed by a connect().

    Tested-by: Linus Torvalds <torvalds@linux-foundation.org>
    Reported-by: Wen Xu <hotdog3645@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    net/ipv4/ping.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/net/ipv4/ping.c b/net/ipv4/ping.c
    index 7e079a2..64735ad 100644
    --- a/net/ipv4/ping.c
    +++ b/net/ipv4/ping.c
    @@ -154,6 +154,7 @@ void ping_unhash(struct sock *sk)
    if (sk_hashed(sk)) {
    write_lock_bh(&ping_table.lock);
    hlist_nulls_del(&sk->sk_nulls_node);
    + sk_nulls_node_init(&sk->sk_nulls_node);
    sock_put(sk);
    isk->inet_num = 0;
    isk->inet_sport = 0;
    --
    1.9.1


    \
     
     \ /
      Last update: 2015-05-05 23:41    [W:4.073 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site