Messages in this thread Patch in this message | | | From | Valentin Rothberg <> | Date | Mon, 4 May 2015 08:49:13 +0200 | Subject | Fwd: [PATCH] arch/arm/mm/proc-arm925.S: remove dead #ifdef block |
| |
Hi Russell,
I saw the patch below has made its way into today's linux-next tree. Last week I sent a few patches fixing similar issues in arm, but I was not sure if you are interested in such things to get fixed. Are you interested? Another question: Do you have means to notify the sender when you apply a patch? Besides having fun doing such things, I also have some research interest in it and I archive Kconfig related emails; a notification mail would make it easier.
Kind regards, Valentin
---------- Forwarded message ---------- From: Valentin Rothberg <valentinrothberg@gmail.com> Date: Tue, Apr 28, 2015 at 6:45 PM Subject: [PATCH] arch/arm/mm/proc-arm925.S: remove dead #ifdef block To: linux@arm.linux.org.uk, ard.biesheuvel@linaro.org, nico@linaro.org, nsekhar@ti.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Valentin Rothberg <valentinrothberg@gmail.com>
The block could never be compiled; CPU_ICACHE_STREAMING_DISABLE has not been defined in Kconfig since the very first Git commit. Hence, we can safely remove the entire block.
Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com> --- There is a similar looking option 'CPU_ICACHE_DISABLE'. However, I decided to remove the entire block since it could not be compiled for such a long time.
I detected this issue with scripts/checkkconfigsymbols.py --- arch/arm/mm/proc-arm925.S | 3 --- 1 file changed, 3 deletions(-)
diff --git a/arch/arm/mm/proc-arm925.S b/arch/arm/mm/proc-arm925.S index ede8c54ab4aa..32a47cc19076 100644 --- a/arch/arm/mm/proc-arm925.S +++ b/arch/arm/mm/proc-arm925.S @@ -441,9 +441,6 @@ ENTRY(cpu_arm925_set_pte_ext) .type __arm925_setup, #function __arm925_setup: mov r0, #0 -#if defined(CONFIG_CPU_ICACHE_STREAMING_DISABLE) - orr r0,r0,#1 << 7 -#endif
/* Transparent on, D-cache clean & flush mode. See NOTE2 above */ orr r0,r0,#1 << 1 @ transparent mode on -- 2.1.4
| |