| From | Jiri Slaby <> | Subject | [PATCH 3.12 153/155] dm: hold suspend_lock while suspending device during device deletion | Date | Tue, 7 Apr 2015 14:52:02 +0200 |
| |
From: Mikulas Patocka <mpatocka@redhat.com>
3.12-stable review patch. If anyone has any objections, please let me know.
===============
commit ab7c7bb6f4ab95dbca96fcfc4463cd69843e3e24 upstream.
__dm_destroy() must take the suspend_lock so that its presuspend and postsuspend calls do not race with an internal suspend.
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com> Signed-off-by: Mike Snitzer <snitzer@redhat.com> Signed-off-by: Jiri Slaby <jslaby@suse.cz> --- drivers/md/dm.c | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/drivers/md/dm.c b/drivers/md/dm.c index 93f3fe443657..5a0b1742f794 100644 --- a/drivers/md/dm.c +++ b/drivers/md/dm.c @@ -2439,10 +2439,16 @@ static void __dm_destroy(struct mapped_device *md, bool wait) set_bit(DMF_FREEING, &md->flags); spin_unlock(&_minor_lock); + /* + * Take suspend_lock so that presuspend and postsuspend methods + * do not race with internal suspend. + */ + mutex_lock(&md->suspend_lock); if (!dm_suspended_md(md)) { dm_table_presuspend_targets(map); dm_table_postsuspend_targets(map); } + mutex_unlock(&md->suspend_lock); /* dm_put_live_table must be before msleep, otherwise deadlock is possible */ dm_put_live_table(md, srcu_idx); -- 2.3.4
|