lkml.org 
[lkml]   [2015]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] fuse: avoid clobbering fc->release with fuse_conn_init(fc)
Date
fuse_conn_init(fc) zeros the entire fc structure before it assigns
specific values. Since fc->release is set before fuse_conn_init(fc)
is called, the value gets set to zero, which results in a NULL pointer
deference when fc->release() is called. Fix the problem by assigning
fc->release after calling fuse_conn_init(fc) instead of before.

Signed-off-by: Jeremiah Mahler <jmmahler@gmail.com>
Fixes: daccc092d1a2 ("fuse: initialize fc->release before calling it")
---
fs/fuse/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c
index 01ff55d..2913db2 100644
--- a/fs/fuse/inode.c
+++ b/fs/fuse/inode.c
@@ -1076,8 +1076,8 @@ static int fuse_fill_super(struct super_block *sb, void *data, int silent)
if (!fc)
goto err_fput;

- fc->release = fuse_free_conn;
fuse_conn_init(fc);
+ fc->release = fuse_free_conn;

fud = fuse_dev_alloc(fc);
if (!fud)
--
2.1.4


\
 
 \ /
  Last update: 2015-06-01 03:41    [W:0.087 / U:0.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site