Messages in this thread Patch in this message | | | From | Colin King <> | Subject | [PATCH] usb: isp1760: fix null dereference if kzalloc returns null | Date | Sun, 31 May 2015 23:00:49 +0100 |
| |
From: Colin Ian King <colin.king@canonical.com>
If kzalloc returns null then isp1760_ep_alloc_request performs a null pointer deference on req. Check for null to avoid this.
Detected with smatch static analysis:
drivers/usb/isp1760/isp1760-udc.c:816 isp1760_ep_alloc_request() error: potential null dereference 'req'. (kzalloc returns null)
Signed-off-by: Colin Ian King <colin.king@canonical.com> --- drivers/usb/isp1760/isp1760-udc.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/usb/isp1760/isp1760-udc.c b/drivers/usb/isp1760/isp1760-udc.c index 3fc4fe7..18ebf5b 100644 --- a/drivers/usb/isp1760/isp1760-udc.c +++ b/drivers/usb/isp1760/isp1760-udc.c @@ -812,6 +812,8 @@ static struct usb_request *isp1760_ep_alloc_request(struct usb_ep *ep, struct isp1760_request *req; req = kzalloc(sizeof(*req), gfp_flags); + if (!req) + return NULL; return &req->req; } -- 2.1.4
| |