lkml.org 
[lkml]   [2015]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Staging: lustre: Replace kzalloc followed by memcpy with kmemdup


On Sat, 30 May 2015, Dighe, Niranjan (N.) wrote:

> Replace kzalloc followed by memcpy by kmemdup. This patch was generated
> by 'make coccicheck'
>
> Signed-off-by: Niranjan Dighe <ndighe@visteon.com>

You need a --- here. Also it is nice to put a diffstat below.

julia

>
> diff --git a/drivers/staging/lustre/lustre/obdclass/obd_config.c b/drivers/staging/lustre/lustre/obdclass/obd_config.c
> index 0bda9c5..274cae3 100644
> --- a/drivers/staging/lustre/lustre/obdclass/obd_config.c
> +++ b/drivers/staging/lustre/lustre/obdclass/obd_config.c
> @@ -866,29 +866,26 @@ int class_add_profile(int proflen, char *prof, int osclen, char *osc,
> INIT_LIST_HEAD(&lprof->lp_list);
>
> LASSERT(proflen == (strlen(prof) + 1));
> - lprof->lp_profile = kzalloc(proflen, GFP_NOFS);
> + lprof->lp_profile = kmemdup(prof, proflen, GFP_NOFS);
> if (lprof->lp_profile == NULL) {
> err = -ENOMEM;
> goto free_lprof;
> }
> - memcpy(lprof->lp_profile, prof, proflen);
>
> LASSERT(osclen == (strlen(osc) + 1));
> - lprof->lp_dt = kzalloc(osclen, GFP_NOFS);
> + lprof->lp_dt = kmemdup(osc, osclen, GFP_NOFS);
> if (lprof->lp_dt == NULL) {
> err = -ENOMEM;
> goto free_lp_profile;
> }
> - memcpy(lprof->lp_dt, osc, osclen);
>
> if (mdclen > 0) {
> LASSERT(mdclen == (strlen(mdc) + 1));
> - lprof->lp_md = kzalloc(mdclen, GFP_NOFS);
> + lprof->lp_md = kmemdup(mdc, mdclen, GFP_NOFS);
> if (lprof->lp_md == NULL) {
> err = -ENOMEM;
> goto free_lp_dt;
> }
> - memcpy(lprof->lp_md, mdc, mdclen);
> }
>
> list_add(&lprof->lp_list, &lustre_profile_list);
> --
> 1.9.1
>


\
 
 \ /
  Last update: 2015-05-30 15:21    [W:0.042 / U:13.404 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site