[lkml]   [2015]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 1/2] staging: dgnc: use schedule_timeout_interruptible()
On Fri, May 29, 2015 at 06:41:27PM +0200, Nicholas Mc Guire wrote:
> API consolidation with coccinelle found:
> ./drivers/staging/dgnc/dgnc_utils.c:16:1-17:
> consolidation with schedule_timeout_*() recommended
> This is a 1:1 conversion with respect to schedule_timeout() to the
> schedule_timeout_interruptible() helper only - so only an API
> consolidation to improve readability. The timeout was being passed
> as (ms * HZ) / 1000 but that is not reliable as it allows the timeout
> to become 0 for small values of ms. As this cut-off is HZ dependent
> this is most likely not intended, so the timeout is converted with
> msecs_to_jiffies which handles all corener-cases correctly.
> Patch was compile tested with x86_64_defconfig + CONFIG_STAGING=y,
> Patch is against 4.1-rc5 (localversion-next is -next-20150529)

Can you resend this without these two sentances? They are not needed
and are just "implied" as you should have done this for every patch


greg k-h

 \ /
  Last update: 2015-05-31 04:21    [W:0.071 / U:3.464 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site