[lkml]   [2015]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] staging: unisys: use schedule_timeout_interruptible()
On Fri, May 29, 2015 at 05:31:16PM +0200, Nicholas Mc Guire wrote:
> API consolidation with coccinelle found:
> ./drivers/staging/unisys/visorbus/periodic_work.c:196:3-19:
> consolidation with schedule_timeout_*() recommended
> This is a 1:1 conversion with respect to schedule_timeout() to the
> schedule_timeout_interruptible() helper only - so only an API
> consolidation to improve readability. The hard coded timeout of 10
> jiffies is HZ dependent which it should not be, so it is converted
> with msecs_to_jiffies.
> Patch was compile tested with x86_64_defconfig + CONFIG_STAGING=y,
> Patch is against 4.1-rc5 (localversion-next is -next-20150529)
> Signed-off-by: Nicholas Mc Guire <>
> ---
> As the actually intended timeout is not documented and msecs_to_jiffies
> timeouts can be a factor 10 different from the current effective timeout
> this needs to be checked by someone who knows the details of this driver
> in any case it should be passed in a HZ independent manner.

I need an ack from the maintainers before I can take this.


greg k-h

 \ /
  Last update: 2015-05-31 04:21    [W:0.034 / U:13.644 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site