lkml.org 
[lkml]   [2015]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Staging: rtl8192e: Timer setup using macro rather assignment
On Mon, May 18, 2015 at 10:12:42PM +0530, Sudip Mukherjee wrote:
> On Mon, May 18, 2015 at 09:26:03AM -0700, Joe Perches wrote:
> > On Mon, 2015-05-18 at 21:35 +0530, Sudip Mukherjee wrote:
> > > On Mon, May 18, 2015 at 02:44:15PM +0000, DHANAPAL, GNANACHANDRAN (G.) wrote:
> > > > setup_timer is used for timer parameter setup rather than direct
> > > > assignment
> > > >
> > > > Signed-off-by: Gnanachandran Dhanapal <gdhanapa@visteon.com>
> > >
> > > your From: name and Signed-off-by: names are not matching. They should
> > > be same.
> >
> > If there's a specific "From: " in the _body_ of the email,
> > that's true, but the sender email "From: " header and the
> > Signed-off-by: line do not have to match.
> But Greg usually rejects these patches where the sender "From:" header
> and Signed-off-by: doesnot match. Just for example:
>
> https://lkml.org/lkml/2014/11/25/924

Yes, I can't take it where it doesn't match up.

Sometimes I miss it, but when it's pointed out, I will not accept it.

thanks,

greg k-h


\
 
 \ /
  Last update: 2015-05-31 03:21    [W:0.037 / U:5.160 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site