[lkml]   [2015]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v3] rtc: pcf8563 fix: return -EINVAL if we read an invalid time.
On 28/05/2015 at 08:48:45 +0200, Jan Kardell wrote :
> Return -EINVAL if the voltage low bit is set to avoid getting a bogus
> time at boot.
> There was a comment stating that util-linux hwclock refuses to set a
> new time if we return an error code on read, but at least the current
> version do set the time as expected. Remove the comment and the check
> for valid time, and let the rtc core check it for us.
> Changes in v2: Remove the test for invalid time. Change dev_err to
> dev_info when voltage low is set.
> Changes in v3: Use dev_err when voltage low is set.
> Signed-off-by: Jan Kardell <>
> ---
> drivers/rtc/rtc-pcf8563.c | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)

Applied, thanks.

Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering

 \ /
  Last update: 2015-05-31 00:41    [W:0.036 / U:3.112 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site