lkml.org 
[lkml]   [2015]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] fix code style in socklnd_proto.c
On Mon, Apr 06, 2015 at 11:21:33PM +0900, Kai Katsumata wrote:
> fix coding style by ./scripts/checkpatch.pl.
> fix 80 charracters limit, space prohibited between function name and
> open parenthesis '('
> and braces {} are not necessary for single statement blocks.

That's two different things, so this should be two different patches.
Each patch should only do one logical thing.

>
> Before patch is html format. But this is plain text format.
> Before patch is From: line didn't match the Signed-off-by line. Align
> the these lines.

This paragraph doesn't need to be here, please put it below the --- line
so it doesn't show up in the changelog.

thanks,

greg k-h


\
 
 \ /
  Last update: 2015-05-03 21:21    [W:0.050 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site