lkml.org 
[lkml]   [2015]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 3/17] video: fbdev: gbefb: use arch_phys_wc_add() and devm_ioremap_wc()
On Fri, May 29, 2015 at 08:41:44AM +0200, Ingo Molnar wrote:
>
> * Luis R. Rodriguez <mcgrof@do-not-panic.com> wrote:
>
> > + gbe_mem = devm_ioremap_wc(&p_dev->dev, gbe_mem_phys,
> > + gbe_mem_size);
>
> > + gbe_mem = dma_alloc_writecombine(NULL, gbe_mem_size,
> > + &gbe_dma_addr, GFP_KERNEL);
>
> > + par->wc_cookie = arch_phys_wc_add(gbe_mem_phys, gbe_mem_size);
>
> > + arch_phys_wc_del(par->wc_cookie);
>
> > + arch_phys_wc_del(par->wc_cookie);
>
> Could we _please_ rename dma_*_writecombine() to dma_*_wc(), so that the naming is
> coherent across the various APIs?

Sure, OK done. Will send once this series is merged and visible on linux-next.
But who's tree should this go through? Since it depends on this series which
goes through Tomi's tree should it go through there?

Luis


\
 
 \ /
  Last update: 2015-05-30 03:01    [W:0.075 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site