Messages in this thread | | | Date | Fri, 29 May 2015 14:37:20 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] zpool: add EXPORT_SYMBOL for functions |
| |
On Fri, 29 May 2015 12:35:46 -0400 Dan Streetman <ddstreet@ieee.org> wrote:
> On Fri, May 29, 2015 at 12:30 PM, Christoph Hellwig <hch@infradead.org> wrote: > > On Fri, May 29, 2015 at 11:36:05AM -0400, Dan Streetman wrote: > >> because they are available for public use, per zpool.h? If, e.g., > >> zram ever started using zpool, it would need them exported, wouldn't > >> it? > > > > If you want to use it in ram export it in the same series as those > > changes, and explain what the exprots are for in your message body. > > > > I don't want to use it in zram. I wrote zpool, but neglected to > export the functions. They should be exported though. > > What's your reasoning for not wanting them exported?
It's just noise which has no value. Adding exports when there is a demonstrated need is an OK approach.
| |