[lkml]   [2015]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 6/6] edac, mce_amd_inj: Inject errors on NBC for bank 4 errors
On Fri, May 29, 2015 at 01:52:32PM -0500, Aravind Gopalakrishnan wrote:
> Yeah, I do run checkpatch. With this, I think the line was going above 79
> chars. So split it.

Yeah, don't take checkpatch too seriously - only as a hint. Common sense
should be employed, instead. :)

> I thought we split such error messages right?

Right, so string error messages we do not split for easier grepping.

> (amd64_edac and mce_amd.c for example have such instances)

Yeah, those will have to be fixed gradually when we're touching the code
anyway, at some point.


ECO tip #101: Trim your mails when you reply.

 \ /
  Last update: 2015-05-29 21:41    [W:0.069 / U:12.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site