Messages in this thread | | | Date | Fri, 29 May 2015 13:27:34 -0500 | From | Timur Tabi <> | Subject | Re: [PATCH v3 5/6] Watchdog: introduce ARM SBSA watchdog driver |
| |
On 05/29/2015 12:53 PM, Fu Wei wrote: > If this interrupter is triggered, that means system has goes wrong, > who knows what is wrong , > I have to make sure that system get into that routine ,because of the > WS0, if not I won't do panic.
But the interrupt handler is not registered as shared, which means that it cannot be generated by another device.
> And in a interrupter routine , checking the Interrupter status > register is right way to do.
If you get an interrupt, but WS0 is not set, then you should return IRQ_NONE instead of IRQ_HANDLED.
Also, I don't think IRQF_TIMER is correct. It's not a timer interrupt. Watchdogs are *not* timers.
-- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
| |