lkml.org 
[lkml]   [2015]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: me_daq: use schedule_timeout_interruptible()
On Fri, 29 May 2015, Ian Abbott wrote:

> On 29/05/15 16:58, Nicholas Mc Guire wrote:
>> API consolidation with coccinelle found:
>> ./drivers/staging/comedi/drivers/me_daq.c:177:1-17:
>> consolidation with schedule_timeout_*() recommended
>>
>> This is a 1:1 conversion of the current calls to an available helper
>> only - so only an API consolidation to improve readability.
>>
>> Patch was compile tested with x86_64_defconfig + CONFIG_STAGING=y,
>> CONFIG_COMEDI=y, CONFIG_COMEDI_PCI_DRIVERS=y CONFIG_COMEDI_ME_DAQ=m
>>
>> Patch is against 4.1-rc5 (localversion-next is -next-20150529)
>
> Minor niggle: you don't really need to say what version the patch is
> against in the commit message, as the version will have changed by the
> time the patch is committed. It can be mentioned after the "---" marker
> line if relevant, as the stuff after the "---" line does not end up in
> the commit message.
>
makes sense - will move that down for the other cleanups.

thx!
hofrat


\
 
 \ /
  Last update: 2015-05-29 19:21    [W:0.031 / U:0.332 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site