lkml.org 
[lkml]   [2015]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: me_daq: use schedule_timeout_interruptible()
On 29/05/15 16:58, Nicholas Mc Guire wrote:
> API consolidation with coccinelle found:
> ./drivers/staging/comedi/drivers/me_daq.c:177:1-17:
> consolidation with schedule_timeout_*() recommended
>
> This is a 1:1 conversion of the current calls to an available helper
> only - so only an API consolidation to improve readability.
>
> Patch was compile tested with x86_64_defconfig + CONFIG_STAGING=y,
> CONFIG_COMEDI=y, CONFIG_COMEDI_PCI_DRIVERS=y CONFIG_COMEDI_ME_DAQ=m
>
> Patch is against 4.1-rc5 (localversion-next is -next-20150529)

Minor niggle: you don't really need to say what version the patch is
against in the commit message, as the version will have changed by the
time the patch is committed. It can be mentioned after the "---" marker
line if relevant, as the stuff after the "---" line does not end up in
the commit message.

>
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> ---
> drivers/staging/comedi/drivers/me_daq.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/me_daq.c b/drivers/staging/comedi/drivers/me_daq.c
> index d78e919..9ea1ba4 100644
> --- a/drivers/staging/comedi/drivers/me_daq.c
> +++ b/drivers/staging/comedi/drivers/me_daq.c
> @@ -173,8 +173,7 @@ struct me_private_data {
>
> static inline void sleep(unsigned sec)
> {
> - __set_current_state(TASK_INTERRUPTIBLE);
> - schedule_timeout(sec * HZ);
> + schedule_timeout_interruptible(sec * HZ);
> }
>
> static int me_dio_insn_config(struct comedi_device *dev,
>

The patch itself looks fine!

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-


\
 
 \ /
  Last update: 2015-05-29 19:01    [W:0.042 / U:19.024 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site