Messages in this thread | | | Date | Fri, 29 May 2015 17:49:06 +0200 | From | Quentin Lambert <> | Subject | Re: [PATCH] ALSA: aoa: convert bus code to use dev_groups |
| |
On 28/05/2015 17:01, Takashi Iwai wrote: >>> Also, it'd be better to move ATTRIBUTE_GROUPS(soundbus_dev) into >>> soundbus/sysfs.c, and make it this global instead of >>> soundbus_dev_attrs[]. >> Ok, I need to find a nice way to do that because ATTRIBUTE_GROUPS >> declares the >> structure as static. > > If it results in an ungly code, it's fine with the original code, > too. But, maybe with a comment indicating that xxx_dev_attrs[] is > defined in xxx.c. > > Since sound/aoa/soundbus/sysfs is small, a solution would be to merge sound/aoa/soundbus/sysfs.c and sound/aoa/soundus/core.c. Moreover all 172 other usages of the ATTRIBUTE_GROUPS macro define the struct attribute *xxx_attrs[] in the same file they assign the .dev_groups field.
I'm not sure about this change as it seems way more important than adding a comment line as you suggested.
Should I send a patch merging these two files?
Quentin
| |