lkml.org 
[lkml]   [2015]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v10 11/12] x86, mm, pat: Refactor !pat_enabled handling
From
Date
On Fri, 2015-05-29 at 17:13 +0200, Borislav Petkov wrote:
> On Fri, May 29, 2015 at 08:27:08AM -0600, Toshi Kani wrote:
> > This simply preserves the original error check in the code. This error
> > check makes sure that all CPUs have the PAT feature supported when PAT
> > is enabled. This error can only happen when heterogeneous CPUs are
> > installed/emulated on the system/guest. This check may be paranoid, but
> > this cleanup is not meant to modify such an error check.
>
> No, this is a ridiculous attempt to justify crazy code. Please do it
> right. If the cleanup makes the code more insane than it is, then don't
> do it in the first place.

Well, the change is based on this review comment. So, I am not sure
what would be the right thing to do. I am not 100% certain that this
check can be removed, either.
https://lkml.org/lkml/2015/5/22/148

> > Can you consider the patch 10/12-11/12 as a separate patchset from the
> > WT series? If that is OK, I will resubmit 10/12 (BUG->panic) and 11/12
> > (commit log update).
>
> That's not enough. 11/12 is a convoluted mess which needs splitting and
> more detailed explanations in the commit messages.
>
> So no. Read what I said: do the cleanup *first* , *then* add the new
> functionality.
>
> The WT patches shouldn't change all too much from what you have now.
> Also, 11/12 changes stuff which you add in 1/12. This churn is useless
> and shouldn't be there at all.
>
> So you should be able to do the cleanup first and have the WT stuff
> ontop just fine.

OK, I will do the cleanup first and resubmit the patchset based on
tip/master.

Thanks,
-Toshi




\
 
 \ /
  Last update: 2015-05-29 18:21    [W:0.065 / U:3.760 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site