[lkml]   [2015]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH RFC] s390/sclp: pass timeout as HZ independent value
On Fri, May 29, 2015 at 11:51:54AM +0200, Nicholas Mc Guire wrote:
> On Fri, 29 May 2015, Heiko Carstens wrote:
> > Yes, the orginal code seems to be broken. Since I've no idea what the intended
> > timeout value should be, let's simply ask Michael, who wrote this code eight
> > years ago ;)
> > While these lines get touched anyway, it would make sense to use
> > schedule_timeout_interruptible() instead, and get rid of set_current_state().
> >
> Well that is not really equivalent
> schedule_timeout_interruptible() is doing
> __set_current_state not set_current_state
> so that would drop the mb() and no WRITE_ONCE()

And how does that matter in this case?

 \ /
  Last update: 2015-05-29 13:01    [W:0.065 / U:0.796 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site