lkml.org 
[lkml]   [2015]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 03/13] android: binder: refactor binder_thread_write
This patch is ok.

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

On Thu, May 28, 2015 at 04:08:21PM -0700, Riley Andrews wrote:
> +static void binder_call_inc_dec_ref(struct binder_thread *thread,
> + uint32_t target, uint32_t cmd)
> +{
> + struct binder_proc *proc = thread->proc;
> + struct binder_ref *ref;
> + const char *debug_string;
> +
> + if (target == 0 && binder_context_mgr_node &&
> + (cmd == BC_INCREFS || cmd == BC_ACQUIRE)) {
> + ref = binder_get_ref_for_node(proc, binder_context_mgr_node);
> + if (ref->desc != target) {
> + binder_user_error("%d:%d tried to acquire reference to desc 0, got %d instead\n",
> + proc->pid, thread->pid, ref->desc);
> + return;

Presumably we never hit this error condition. In the original code we
printed an error and continued but now we bail on error. Presumably
this is a theoretical bug fix which doesn't affect real life so I will
allow it. But in the future don't mix behaviour changes with clean up
patches.

> + }
> + } else {
> + ref = binder_get_ref(proc, target);
> + }
> + if (!ref) {

In the original code this was "if (ref == NULL)". Please don't mix
these kinds of cleanups with moving code around because it makes it
harder for me to review. Do that in a separate patch.

regards,
dan carpenter



\
 
 \ /
  Last update: 2015-05-29 12:41    [W:0.071 / U:39.320 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site