lkml.org 
[lkml]   [2015]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] fixup! dmaengine: pxa_dma: add debug information
From
Date
On Fri, 2015-05-29 at 11:29 +0200, robert.jarzmik@free.fr wrote:
> ----- Mail original -----
> De: "Vinod Koul" <vinod.koul@intel.com>
> On Wed, May 27, 2015 at 11:23:40PM +0200, Robert Jarzmik wrote:
> > This fixes the following error:
[]
> And with a a bit closer look check this commit, especially the date :
> commit 0bac33653b06a5f80a5c04e275eb33db9493b85a
> Author: Joe Perches <joe@perches.com>
> Date: Sat May 23 12:00:38 2015 +1000
>
> fs/seq_file: convert int seq_vprint/seq_printf/etc... returns to void

Hello Robert.

The return value of that dbg_show_requester_chan function
was incorrect and the increment of pos was an example of
why the seq_printf return value was changed to void.

It was a pretty common error and easy to understand given
the expectation that seq_printf should work like printf.

It's a pity it bit you. but this type of patch collision
should be a bit more difficult to reoccur in the future.

cheers, Joe



\
 
 \ /
  Last update: 2015-05-29 12:41    [W:0.037 / U:13.152 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site