lkml.org 
[lkml]   [2015]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/7] net: dsa: add new driver for ar8xxx family
> +static int ar8xxx_set_pad_ctrl(struct dsa_switch *ds, int port, int mode)
> +{
> + int reg;
> +
> + switch (port) {
> + case 0:
> + reg = AR8327_REG_PORT0_PAD_CTRL;
> + break;
> + case 6:
> + reg = AR8327_REG_PORT6_PAD_CTRL;
> + break;
> + default:
> + pr_err("Can't set PAD_CTRL on port %d\n", port);
> + return -EINVAL;
> + }
> +
> + /* DSA only supports 1 CPU port for now, so we'll take the assumption
> + * that P0 is connected to the CPU master_dev.
> + */

I don't like this assumption. Hardware i have with Marvell switches
has the CPU connected to ports 5, or 6, or 0.

Calling dsa_upstream_port() will tell you which is the CPU port.

Andrew


\
 
 \ /
  Last update: 2015-05-29 04:21    [W:0.120 / U:11.480 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site