Messages in this thread Patch in this message | | | From | "Luis R. Rodriguez" <> | Subject | [PATCH] firmware: add missing kfree for work on async call | Date | Thu, 28 May 2015 17:46:42 -0700 |
| |
From: "Luis R. Rodriguez" <mcgrof@suse.com>
The recent fix to use kstrdup_const() failed to add a kfree upon failure of name allocation...
Cc: Ming Lei <ming.lei@canonical.com> Cc: Seth Forshee <seth.forshee@canonical.com> Cc: Kyle McMartin <kyle@kernel.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Luis R. Rodriguez <mcgrof@suse.com> ---
Sorry about that..
drivers/base/firmware_class.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c index 8c3aa3c..9c42883 100644 --- a/drivers/base/firmware_class.c +++ b/drivers/base/firmware_class.c @@ -1307,8 +1307,10 @@ request_firmware_nowait( fw_work->module = module; fw_work->name = kstrdup_const(name, gfp); - if (!fw_work->name) + if (!fw_work->name) { + kfree(fw_work); return -ENOMEM; + } fw_work->device = device; fw_work->context = context; fw_work->cont = cont; -- 2.3.2.209.gd67f9d5.dirty
| |