lkml.org 
[lkml]   [2015]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] numa,sched: only consider less busy nodes as numa balancing destination
On 05/28/2015 07:07 AM, Srikar Dronamraju wrote:
> * riel@redhat.com <riel@redhat.com> [2015-05-27 15:04:28]:
>
>>
>> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
>> index c47bf0dffb34..f655f2ad155d 100644
>> --- a/kernel/sched/fair.c
>> +++ b/kernel/sched/fair.c
>> @@ -1398,6 +1398,30 @@ static void task_numa_find_cpu(struct task_numa_env *env,
>> }
>> }
>>
>> +/* Only move tasks to a NUMA node less busy than the current node. */
>> +static bool numa_has_capacity(struct task_numa_env *env)
>> +{
>> + struct numa_stats *src = &env->src_stats;
>> + struct numa_stats *dst = &env->dst_stats;
>> +
>> + if (src->has_free_capacity && !dst->has_free_capacity)
>> + return false;
>> +
>> + /*
>> + * Only consider a task move if the source has a higher destination
>> + * than the destination, corrected for CPU capacity on each node.
>
> In the above comment, did you mean source has higher load than the
> destination?

Uh yes, indeed. Thanks for spotting that.

Peter, do you want me to send a v2 with the typo fixed, or
is it easier for you to fix up the typo before committing?

--
All rights reversed


\
 
 \ /
  Last update: 2015-05-28 16:21    [W:0.101 / U:0.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site