lkml.org 
[lkml]   [2015]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/3] ahci: Move interrupt enablement code to separate functions
Hello,

On Wed, May 27, 2015 at 10:01:31AM +0200, Robert Richter wrote:
> +static int ahci_init_intx(struct pci_dev *pdev, unsigned int n_ports,
> + struct ahci_host_priv *hpriv)
> +{
> pci_intx(pdev, 1);
> +
> return 0;
> }

Let's please not factor out the above as a separate function. An one
lin function which always returns 0 doesn't really serve any purpose.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2015-05-27 20:41    [W:0.082 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site