Messages in this thread | | | Date | Wed, 27 May 2015 07:53:30 -0700 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v2] staging: lustre: fix non-static symbol warnings reported by sparse |
| |
On Wed, May 27, 2015 at 04:47:56PM +0200, Marcus Folkesson wrote: > Warnings reported by sparse: > > drivers/staging/lustre/lustre/ptlrpc/pinger.c:94:5: > warning: symbol 'ptlrpc_ping' was not declared. Should it be static? > > drivers/staging/lustre/lustre/ptlrpc/pinger.c:113:6: > warning: symbol 'ptlrpc_update_next_ping' was not declared. Should it be static > > drivers/staging/lustre/lustre/ptlrpc/pinger.c:144:6: > warning: symbol 'pinger_check_timeout' was not declared. Should it be static? > > drivers/staging/lustre/lustre/ptlrpc/pinger.c:425:21: > warning: symbol 'ptlrpc_new_timeout' was not declared. Should it be static? > > drivers/staging/lustre/lustre/ptlrpc/pinger.c:551:1: > warning: symbol 'pet_list' was not declared. Should it be static? > > Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com> > --- > drivers/staging/lustre/lustre/ptlrpc/pinger.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-)
What changed in v2 needs to go here, below the --- line, not in a separate email that will get lost, especially as it has a very odd subject line :(
Please fix up and resend.
thanks,
greg k-h
| |