lkml.org 
[lkml]   [2015]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 4/7] timer: Replace timer base by a cpu index
On Wed, May 27, 2015 at 02:52:36PM +0530, Viresh Kumar wrote:
> > + timer->flags = (timer->flags & ~TIMER_BASEMASK) | cpu;
>
> Because 'cpu' is used only once in this routine, maybe we can use
> 'new_base->cpu' here and the line will still be exactly 80 columns
> long.
>
> Not sure, but maybe we can create a inline helper for this operation
> as it is repeated at multiple places.

I suggested bitfields at some point I think. That gets the compiler to
generate those helpers for you.


\
 
 \ /
  Last update: 2015-05-27 14:21    [W:0.294 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site