| Date | Wed, 27 May 2015 14:09:14 +0200 | From | Peter Zijlstra <> | Subject | Re: [patch 4/7] timer: Replace timer base by a cpu index |
| |
On Wed, May 27, 2015 at 02:52:36PM +0530, Viresh Kumar wrote: > > + timer->flags = (timer->flags & ~TIMER_BASEMASK) | cpu; > > Because 'cpu' is used only once in this routine, maybe we can use > 'new_base->cpu' here and the line will still be exactly 80 columns > long. > > Not sure, but maybe we can create a inline helper for this operation > as it is repeated at multiple places.
I suggested bitfields at some point I think. That gets the compiler to generate those helpers for you.
|