lkml.org 
[lkml]   [2015]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/9] mfd: max77693: Store I2C device type as enum and add default unknown
On Sun, 24 May 2015, Krzysztof Kozlowski wrote:

> Store the device type (obtained from i2c_device_id) as an enum and add a
> default type of unknown to distinguish from case when this is not set
> at all.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>
> ---
> include/linux/mfd/max77693-private.h | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)

Applied, thanks.

> diff --git a/include/linux/mfd/max77693-private.h b/include/linux/mfd/max77693-private.h
> index ad67b8235a8d..e3c0afff38d3 100644
> --- a/include/linux/mfd/max77693-private.h
> +++ b/include/linux/mfd/max77693-private.h
> @@ -529,13 +529,18 @@ enum max77693_irq_muic {
> MAX77693_MUIC_IRQ_NR,
> };
>
> +enum max77693_types {
> + TYPE_MAX77693_UNKNOWN,
> + TYPE_MAX77693,
> +};
> +
> struct max77693_dev {
> struct device *dev;
> struct i2c_client *i2c; /* 0xCC , PMIC, Charger, Flash LED */
> struct i2c_client *muic; /* 0x4A , MUIC */
> struct i2c_client *haptic; /* 0x90 , Haptic */
>
> - int type;
> + enum max77693_types type;
>
> struct regmap *regmap;
> struct regmap *regmap_muic;
> @@ -549,8 +554,4 @@ struct max77693_dev {
> int irq;
> };
>
> -enum max77693_types {
> - TYPE_MAX77693,
> -};
> -
> #endif /* __LINUX_MFD_MAX77693_PRIV_H */

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog


\
 
 \ /
  Last update: 2015-05-27 12:41    [W:0.177 / U:8.052 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site