lkml.org 
[lkml]   [2015]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] livepatch: match return value to function signature
On 05/27/2015, 08:56 AM, Nicholas Mc Guire wrote:
> On Mon, 11 May 2015, Jiri Slaby wrote:
>
>> On 05/11/2015, 07:52 AM, Nicholas Mc Guire wrote:
>>> klp_initialized() should return bool but is actually returning
>>> struct kobject * - convert it to a boolean explicitly.
>>>
>>> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
>>
>> Reviewed-by: Jiri Slaby <jslaby@suse.cz>
>>
> sorry for the noise - discussions about a similar "cleanup" in RCU
> resulted Joe Perches <joe@perches.com> clarifying the matter - this
> explicit conversion makes static code checkers happy but is not
> needed for gcc (or C for that mater) - see
> http://lkml.org/lkml/2015/5/24/47
> and ISO/IEC 9899:1999 (c99) 6.8.6.4 subclause 3)

Oh yes and I seem to be inconsistent with replies:
https://lkml.org/lkml/2015/5/26/90

> hofrat

You? Nuremberg, 2010, Stanse?

thanks,
--
js
suse labs


\
 
 \ /
  Last update: 2015-05-27 09:41    [W:0.061 / U:0.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site