Messages in this thread | | | Date | Tue, 26 May 2015 20:30:52 -0700 | From | Mike Kravetz <> | Subject | Re: [PATCH] mm/hugetlb: document the reserve map/region tracking routines |
| |
On 05/26/2015 04:09 PM, Andrew Morton wrote: > On Tue, 26 May 2015 14:27:10 -0700 Mike Kravetz <mike.kravetz@oracle.com> wrote: > >> This is a documentation only patch and does not modify any code. >> Descriptions of the routines used for reserve map/region tracking >> are added. > > Confused. This adds comments which are similar to the ones which were > added by > mm-hugetlb-compute-return-the-number-of-regions-added-by-region_add-v2.patch > and > mm-hugetlb-handle-races-in-alloc_huge_page-and-hugetlb_reserve_pages-v2.patch. > But the comments are a bit different. And this patch madly conflicts > with the two abovementioned patches. > > Maybe the thing to do is to start again, with a three-patch series: > > mm-hugetlb-document-the-reserve-map-region-tracking-routines.patch > mm-hugetlb-compute-return-the-number-of-regions-added-by-region_add-v3.patch > mm-hugetlb-handle-races-in-alloc_huge_page-and-hugetlb_reserve_pages-v3.patch > > while resolving the differences in the new code comments? >
Sorry for the confusion. Naoya and Davidlohr suggested changes to the documentation and code. One suggestion was to create a separate documentation only patch.
I will create a new series as you suggest above.
-- Mike Kravetz
| |