Messages in this thread | | | Date | Tue, 26 May 2015 19:37:02 -0700 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v4 1/1] usb: ulpi: ulpi_init should be executed in subsys_initcall |
| |
On Wed, May 27, 2015 at 09:45:37AM +0800, Lu Baolu wrote: > Phy drivers and the ulpi interface providers depend on the > registration of the ulpi bus. Ulpi registers the bus in > module_init(). This could cause unnecessary probe delays.
What do you mean by "probe delays"?
> > Reported-by: Zhuo Qiuxu <qiuxu.zhuo@intel.com> > Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com> > Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > drivers/usb/common/ulpi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/common/ulpi.c b/drivers/usb/common/ulpi.c > index 0e6f968..01c0c04 100644 > --- a/drivers/usb/common/ulpi.c > +++ b/drivers/usb/common/ulpi.c > @@ -242,7 +242,7 @@ static int __init ulpi_init(void) > { > return bus_register(&ulpi_bus); > } > -module_init(ulpi_init); > +subsys_initcall(ulpi_init);
Hasn't this already been rejected?
confused,
greg k-h
| |