Messages in this thread | | | Date | Tue, 26 May 2015 12:00:25 -0500 | From | Jaime Arrocha <> | Subject | Re: [PATCH 1/2] staging: gdm724x: Remove test for host endian |
| |
On 05/26/2015 10:59 AM, Dan Carpenter wrote: > On Tue, May 26, 2015 at 10:29:44AM -0500, Jaime Arrocha wrote: >> This is the first patch of two. Both patches perform a small clean up >> done to the section for host endian test. Instead of handling endianness >> internally, kernel functions were added for use. > >> The second patch depends on the first one, it is just a small piece >> that is no longer needed. > > This kind of dependencies are built in the the name patch 1/2 and 2/2. > We don't want this kind of meta commentary in the permanent changelog. > If it were needed then it would go under the --- cut off line. > > And anyway, fold patch 1 & 2 together into one patch. Do "one thing" > per patch instead of half a thing per patch. >
Thanks for the feedback. I'll do the corrections needed.
>> >> Signed-off-by: Jaime Arrocha <jarr@kerneldev.net> >> --- > > <--- meta commentary goes here. > >> drivers/staging/gdm724x/gdm_endian.c | 52 +++++++++++++++------------------- >> 1 file changed, 23 insertions(+), 29 deletions(-) >> >> diff --git a/drivers/staging/gdm724x/gdm_endian.c b/drivers/staging/gdm724x/gdm_endian.c >> index f6cc90a..609a433 100644 >> --- a/drivers/staging/gdm724x/gdm_endian.c >> +++ b/drivers/staging/gdm724x/gdm_endian.c >> @@ -11,57 +11,51 @@ >> * GNU General Public License for more details. >> */ >> >> -#include <linux/slab.h> > > Is this related to endianness? >
This was needed because the original code uses memcpy() inside gdm_set_endian() to test for host endianness.
>> +#include<asm/byteorder.h> >> +#ifdef __LITTLE_ENDIAN >> +#include<linux/byteorder/little_endian.h> >> +#else >> +#include<linux/byteorder/big_endian.h> >> +#endif > > Why do we need this? Also the spacing is wrong. >
Yes,this needs to go. It was from an old change where I was obtaining host endianness. It will be replaced by linux/byteorder/generic.h
>> u16 gdm_cpu_to_dev16(struct gdm_endian *ed, u16 x) >> { >> - if (ed->dev_ed == ed->host_ed) >> - return x; >> - >> - return Endian16_Swap(x); >> + if (ed->dev_ed == ENDIANNESS_LITTLE) >> + return __cpu_to_le16(x); >> + else >> + return __cpu_to_be16(x); > > Use cpu_to_le16() no underscore versions everywhere. The other is for > code which is shared with usespace. > > regards, > dan carpenter > >
| |