lkml.org 
[lkml]   [2015]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 4/4] ozwpan: unchecked signed subtraction leads to DoS
On Tue, May 26, 2015 at 02:17:49PM +0200, Jason A. Donenfeld wrote:
> diff --git a/drivers/staging/ozwpan/ozusbsvc1.c b/drivers/staging/ozwpan/ozusbsvc1.c
> index 8552053..1bde6aa 100644
> --- a/drivers/staging/ozwpan/ozusbsvc1.c
> +++ b/drivers/staging/ozwpan/ozusbsvc1.c
> @@ -326,11 +326,13 @@ static void oz_usb_handle_ep_data(struct oz_usb_ctx *usb_ctx,
> struct oz_multiple_fixed *body =
> (struct oz_multiple_fixed *)data_hdr;
> u8 *data = body->data;
> - int n;
> + unsigned int n;
> if (!body->unit_size)
> break;
> n = (len - sizeof(struct oz_multiple_fixed)+1)
> / body->unit_size;
> + if (n > len / body->unit_size)
> + break;

You sure do like wrapping to a high value and testing the result for
wrapping instead of validating before doing the subtraction...

regards,
dan carpenter



\
 
 \ /
  Last update: 2015-05-26 16:41    [W:0.091 / U:0.492 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site