lkml.org 
[lkml]   [2015]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] char:agp:amd64-agp - Change 1 to true for bool type
Am 25.05.2015 um 23:14 schrieb Shailendra Verma:
> Hello Richard,
>
> I will separate both the changes and will send the patches to you.
>
> What issue does this fix? IOW why is assigning 1 wrong?
>
>>>>> Yes, you are correct. There will be no issue in assigning 1 to the variable. But according to coding guidelines we should only use true/false for bool type variables.

Really? I don't see this in Documentation/CodingStyle and checkpatch.pl does not bark either.
IMHO it is a matter of taste. But the individual maintainer has to decide. :-)

Thanks,
//richard

P.s: Please don't crop the list of CC when replying.


\
 
 \ /
  Last update: 2015-05-25 23:41    [W:0.153 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site